feat: improve playlist counts #29381
Conversation
pauldambra
commented
Feb 28, 2025
•
pauldambra
commented
- make the out put a little clearer for debugging since this isn't released yet
- also include whether the value increased
- and how many are unwatched
- refactor the data we're passing around a little
- improve the logging of errors so we can see the failing filters/queries to use as test cases
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| id_list = count_data.get("session_ids", None) | ||
| recordings_counts["query_count"] = len(id_list) if id_list else 0 | ||
| recordings_counts["has_more"] = count_data.get("has_more", False) | ||
| id_list: list[str] = count_data.get("session_ids", None) |
There was a problem hiding this comment.
messy, but wrapped in a try/catch and only here so we can validate behind a flag
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the session recording playlist counts feature with more detailed information and improved debugging capabilities.
- Added
recordings_countsstructure infrontend/src/types.tswith separate interfaces for collection and saved filters counts, including watched counts and increase indicators - Updated mock data in
recording_playlists.tsto include the new count structure with watched/unwatched information - Enhanced tooltip display in
SavedSessionRecordingPlaylists.tsxwith tabular format showing both total and unwatched counts - Renamed
_current_user_viewedtocurrent_user_viewedinsession_recording_api.pyto make it publicly accessible - Improved error logging in
recordings_that_match_playlist_filters.pyby adding playlist short IDs and filter information - Added visual indicator (up arrow) when saved filters count has increased
9 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.py
Show resolved
Hide resolved
ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.py
Show resolved
Hide resolved
ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.py
Show resolved
Hide resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| "filters": playlist.filters if playlist else None, | ||
| "query": query, |
There was a problem hiding this comment.
most important change here is grabbing these failing filters/queries so we can figure out the transformations the FE is doing that the BE is missing
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
